ppkarwasz commented on PR #3217: URL: https://github.com/apache/logging-log4j2/pull/3217#issuecomment-2543319236
@jaykataria1111 , > > The log4j-core-java9 package has a lot of dummy classes, whose purpose is to make the module compilable, they are not packaged. Can you remove those dummy classes too > > 1. What does it mean to make the module "compatible"? To make it "compilable". The `log4j-core-java9` module is compiled **before** `log4j-core` and has no access to the classes of `log4j-core`. In order to compile a class like [`SystemClock`](https://github.com/apache/logging-log4j2/blob/2.x/log4j-core-java9/src/main/java/org/apache/logging/log4j/core/util/SystemClock.java) we had to add to `log4j-core-java9` also the classes it depends upon, e.g., those in the [`core.time` directory](https://github.com/apache/logging-log4j2/tree/2.x/log4j-core-java9/src/main/java/org/apache/logging/log4j/core/time). These are the classes that I call "dummy" classes. > 2. they are not packaged - How do I identify the classes that are packaged. We use the Maven Assembly plugin to package the classes in `log4j-core-java9`. There is [an explicit list of classes to package in the `java9.xml` descriptor](https://github.com/apache/logging-log4j2/blob/2.x/log4j-core-java9/src/assembly/java9.xml). > 3. How do I identify these dummy classes? They should have a comment near the top that says that they are "dummy" or something equivalent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
