ppkarwasz commented on code in PR #3217:
URL: https://github.com/apache/logging-log4j2/pull/3217#discussion_r1883779194
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/util/SystemClock.java:
##########
@@ -16,10 +16,15 @@
*/
package org.apache.logging.log4j.core.util;
+import java.time.Instant;
+import org.apache.logging.log4j.core.time.MutableInstant;
+import org.apache.logging.log4j.core.time.PreciseClock;
+
/**
* Implementation of the {@code Clock} interface that returns the system time.
+ * @since 2.25
Review Comment:
The class itself is older, so we should remove the `@since`.
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/util/SystemClock.java:
##########
@@ -29,4 +34,13 @@ public final class SystemClock implements Clock {
public long currentTimeMillis() {
return System.currentTimeMillis();
}
+
+ /**
+ * {@inheritDoc}
+ */
Review Comment:
Personally I find `{@inheritDoc}` a little bit useless, since IDEs will look
at the Javadoc of the parent class/implemented interface anyway, if the Javadoc
is missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
