ppkarwasz commented on code in PR #3263: URL: https://github.com/apache/logging-log4j2/pull/3263#discussion_r1876674213
########## log4j-core-test/src/test/java/org/apache/logging/log4j/core/LoggerMessageFactoryCustomizationTest.java: ########## @@ -24,34 +24,36 @@ import org.apache.logging.log4j.message.MessageFactory; import org.apache.logging.log4j.message.ParameterizedMessageFactory; import org.junit.jupiter.api.Test; -import org.junitpioneer.jupiter.ClearSystemProperty; import org.junitpioneer.jupiter.SetSystemProperty; +@SetSystemProperty( Review Comment: > 1. Passing `MF`s as arguments to `Logger::new` (all `MF`-related properties are cleared before the test) This PR moved the initialization of the default `MessageFactory` and `FlowMessageFactory` to the **static** initialization of the `LoggerContext` class. Clearing the `MF`-related properties before the test doesn't change anything. The PR also reverts the (IMHO overly-specific) Javadoc for the `Logger` constructors introduced in https://github.com/apache/logging-log4j2/commit/3efd59e49323038c05d8db9d912e850cd0b23134, with a simple "the `MessageFactory` and `FlowMessageFactory` parameters should not be `null`. `null` is allowed for BC". **Note**: some changes, like deprecating the `Logger` constructor without a `FlowMessageFactory` parameter require a minor version bump. I'll do that in `2.25.0`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
