vy commented on code in PR #3263: URL: https://github.com/apache/logging-log4j2/pull/3263#discussion_r1876611981
########## log4j-core-test/src/test/java/org/apache/logging/log4j/core/LoggerMessageFactoryCustomizationTest.java: ########## @@ -24,34 +24,36 @@ import org.apache.logging.log4j.message.MessageFactory; import org.apache.logging.log4j.message.ParameterizedMessageFactory; import org.junit.jupiter.api.Test; -import org.junitpioneer.jupiter.ClearSystemProperty; import org.junitpioneer.jupiter.SetSystemProperty; +@SetSystemProperty( Review Comment: I would like to see tests for these two cases: 1. Passing `MF`s as arguments to `Logger::new` (all `MF`-related properties are cleared before the test) 2. Passing `MF`s as properties Can you point me the lines where you do these checks, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
