ppkarwasz commented on PR #3228: URL: https://github.com/apache/logging-log4j2/pull/3228#issuecomment-2503604797
> I made the same objection then but was assured that by using provided scope users would have no problems if the dependency is missing. If that really isn’t the case then the dependency should be removed and a different solution should be found. I don't consider a compiler warning (if the [`-Xlint:all`](https://docs.oracle.com/en/java/javase/21/docs/specs/man/javac.html#option-Xlint-custom) linter option is enabled) to be a real problem. Besides, users can always disable the [`classfile`] category in the linter: it contains only two warnings (see [this comment](https://github.com/apache/logging-log4j2/issues/3110#issuecomment-2423586754)) and both of them are pretty harmless. If I understand correctly, your `-1` only applies to the additional dependency in `log4j-api`, while you are OK with adding it to the other artifacts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
