rgoers commented on code in PR #3228:
URL: https://github.com/apache/logging-log4j2/pull/3228#discussion_r1855273603
##########
log4j-api/pom.xml:
##########
@@ -63,16 +63,19 @@
<dependencies>
<dependency>
- <groupId>org.jspecify</groupId>
- <artifactId>jspecify</artifactId>
+ <groupId>org.osgi</groupId>
+ <artifactId>org.osgi.core</artifactId>
<scope>provided</scope>
</dependency>
+ <!--
+ ~ Effectively optional, but included due to its size and the compilation
warnings its absence causes.
+ -->
<dependency>
- <groupId>org.osgi</groupId>
- <artifactId>org.osgi.core</artifactId>
- <scope>provided</scope>
+ <groupId>org.jspecify</groupId>
+ <artifactId>jspecify</artifactId>
Review Comment:
-1
We have always had a rule that Log4j-API will have no required dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
