vy commented on code in PR #2622: URL: https://github.com/apache/logging-log4j2/pull/2622#discussion_r1616810454
########## src/site/resources/.htaccess: ########## @@ -32,12 +32,14 @@ RewriteRule "^(.+)$" "$1.html" # From this point rules match against the URI to the real file, with "/log4j/2.x/" stripped. # The content moved between pages +RewriteRule "^articles\.html$" "manual/index.html" [R=permanent] RewriteRule "^log4j-core/apidocs(.*)$" "javadoc/log4j-core$1" [R=permanent] RewriteRule "^manual/api-separation\.html$" "manual/api.html" [R=permanent] -RewriteRule "^manual/scala-api\.html$" "/log4j/scala/index.html" [R=permanent] +RewriteRule "^manual/scala-api\.html$" "/log4j/scala" [R=permanent] Review Comment: Sorry, I am against this. `/log4j/scala` is an external site and I don't want to have assumptions on its implementation. This approach is future-proof against the problems you're suggesting to fix, i.e., `/index.html` has been moved to `/latest/index.html`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
