ppkarwasz commented on code in PR #2622: URL: https://github.com/apache/logging-log4j2/pull/2622#discussion_r1616796351
########## src/site/resources/.htaccess: ########## @@ -32,12 +32,14 @@ RewriteRule "^(.+)$" "$1.html" # From this point rules match against the URI to the real file, with "/log4j/2.x/" stripped. # The content moved between pages +RewriteRule "^articles\.html$" "manual/index.html" [R=permanent] RewriteRule "^log4j-core/apidocs(.*)$" "javadoc/log4j-core$1" [R=permanent] RewriteRule "^manual/api-separation\.html$" "manual/api.html" [R=permanent] -RewriteRule "^manual/scala-api\.html$" "/log4j/scala/index.html" [R=permanent] +RewriteRule "^manual/scala-api\.html$" "/log4j/scala" [R=permanent] Review Comment: ```suggestion RewriteRule "^manual/scala-api\.html$" "/log4j/scala/latest/index.html" [R=permanent] ``` ########## src/site/resources/.htaccess: ########## @@ -47,22 +49,22 @@ RewriteRule "^runtime-dependencies\.html$" "manual/installation.html" [R=permane # if the URI path is `/log4j/2.x/log4j-api/foo` we must match `log4j-api.html/foo`. RewriteRule "^log4j-1\.2-api\.html/index\.html$" "log4j-1.2-api.html" [R=permanent] RewriteRule "^log4j-api\.html/apidocs(.*)$" "javadoc/log4j-api$1" [R=permanent] -RewriteRule "^log4j-api\.html/index\.html" "log4j-api.html" [R=permanent] +RewriteRule "^log4j-api\.html/index\.html" "manual/api.html" [R=permanent] RewriteRule "^log4j-appserver\.html/index\.html$" "log4j-appserver.html" [R=permanent] RewriteRule "^log4j-cassandra\.html/index\.html$" "log4j-cassandra.html" [R=permanent] RewriteRule "^log4j-couchdb\.html/index\.html$" "log4j-couchdb.html" [R=permanent] RewriteRule "^log4j-docker\.html/index\.html$" "log4j-docker.html" [R=permanent] RewriteRule "^log4j-flume-ng\.html/index\.html$" "log4j-flume-ng.html" [R=permanent] RewriteRule "^log4j-iostreams\.html/index\.html$" "log4j-iostreams.html" [R=permanent] RewriteRule "^log4j-jakarta-web\.html/index\.html$" "log4j-jakarta-web.html" [R=permanent] -RewriteRule "^log4j-jcl\.html/index\.html$" "log4j-jcl.html" [R=permanent] -RewriteRule "^log4j-jmx-gui\.html/index\.html$" "log4j-jmx-gui.html" [R=permanent] -RewriteRule "^log4j-jpl\.html/index\.html$" "log4j-jpl.html" [R=permanent] -RewriteRule "^log4j-jul\.html/index\.html$" "log4j-jul.html" [R=permanent] +RewriteRule "^log4j-jcl\.html/index\.html$" "manual/installation.html#impl-core-bridge-jcl" [R=permanent] +RewriteRule "^log4j-jmx-gui\.html/index\.html$" "/log4j/jmx-gui" [R=permanent] Review Comment: ```suggestion RewriteRule "^log4j-jmx-gui\.html/index\.html$" "/log4j/jmx-gui/latest/index.html" [R=permanent] ``` I would apply the same convention to links between subprojects as we do for links inside the same project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
