erikmav commented on code in PR #119:
URL: https://github.com/apache/logging-log4net/pull/119#discussion_r1520076453
##########
src/log4net/Appender/RollingFileAppender.cs:
##########
@@ -1376,19 +1327,22 @@ protected void RollOverSize()
CloseFile(); // keep windows happy.
LogLog.Debug(declaringType, "rolling over count [" +
((CountingQuietTextWriter)QuietWriter).Count + "]");
- LogLog.Debug(declaringType, "maxSizeRollBackups [" +
m_maxSizeRollBackups + "]");
+ LogLog.Debug(declaringType, "maxSizeRollBackups [" + MaxSizeRollBackups
+ "]");
LogLog.Debug(declaringType, "curSizeRollBackups [" +
m_curSizeRollBackups + "]");
- LogLog.Debug(declaringType, "countDirection [" + m_countDirection + "]");
+ LogLog.Debug(declaringType, "countDirection [" + CountDirection + "]");
- RollOverRenameFiles(File);
+ if (File is not null)
+ {
+ RollOverRenameFiles(File);
Review Comment:
My 4-spaces settings were fighting the 2-space code. Added a .editorconfig
in the next push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
