erikmav commented on code in PR #119:
URL: https://github.com/apache/logging-log4net/pull/119#discussion_r1520071475
##########
src/log4net/Appender/FileAppender.cs:
##########
@@ -779,16 +782,26 @@ public override void ActivateOptions()
{
if (m_mutex == null)
{
- string mutexFriendlyFilename = CurrentAppender.File
- .Replace("\\", "_")
- .Replace(":", "_")
- .Replace("/", "_");
+ if (CurrentAppender is not null)
Review Comment:
Examined but prefer to keep this one, the outer if has no else{Error()}
because a null CurrentAppender can be ignored, whereas the inner if has an
error output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
