[ 
https://issues.apache.org/jira/browse/LOG4J2-2639?focusedWorklogId=265428&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-265428
 ]

ASF GitHub Bot logged work on LOG4J2-2639:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Jun/19 18:30
            Start Date: 23/Jun/19 18:30
    Worklog Time Spent: 10m 
      Work Description: carterkozak commented on issue #284: LOG4J2-2639 - 
Allow logging calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#issuecomment-504775782
 
 
   > Calling log twice on the same LogBuilder would result in 2 identical log 
messages, other than the timestamp
   
   I think parameter values are mutated in gc free mode after the first event 
is logged, I would expect the second invocation (assuming it is executed after 
a few microseconds) would have all null parameters.
   
   > We could easily add the current thread id to DefaultLogBuilder to verify 
it is only used on a single thread but is it worth the overhead of checking 
that on every method call?
   
   Maybe only the `log()` invocation?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 265428)
    Time Spent: 1h 40m  (was: 1.5h)

> Allow log event to be created using the builder pattern.
> --------------------------------------------------------
>
>                 Key: LOG4J2-2639
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2639
>             Project: Log4j 2
>          Issue Type: Task
>          Components: API
>    Affects Versions: 3.0.0
>            Reporter: Ralph Goers
>            Priority: Major
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> In some cases it would be convenient to create log events using a builder 
> pattern. One advantage of this approach is that it would allow the location 
> information to be more easily provided.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to