[
https://issues.apache.org/jira/browse/LOG4J2-2639?focusedWorklogId=265417&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-265417
]
ASF GitHub Bot logged work on LOG4J2-2639:
------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jun/19 17:37
Start Date: 23/Jun/19 17:37
Worklog Time Spent: 10m
Work Description: carterkozak commented on pull request #284: LOG4J2-2639
- Allow logging calls to be constructed using a builder pattern
URL: https://github.com/apache/logging-log4j2/pull/284#discussion_r296490390
##########
File path:
log4j-api/src/main/java/org/apache/logging/log4j/internal/LogBuilder.java
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache license, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the license for the specific language governing permissions and
+ * limitations under the license.
+ */
+package org.apache.logging.log4j.internal;
+
+import org.apache.logging.log4j.Marker;
+import org.apache.logging.log4j.message.Message;
+
+/**
+ * Class Description goes here.
+ */
+public interface LogBuilder {
+
+ public static final LogBuilder INSTANCE = new LogBuilder() {};
Review comment:
I think this would be easier to follow if this was named something along the
lines of `NOP`, `LogBuilder.INSTANCE` sounds a lot like the DefaultLogBuilder.
Should these be default methods? While it's nice to avoid causing breaks
when we add new methods, it's unfortunate that we will be potentially throwing
data away.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 265417)
Time Spent: 20m (was: 10m)
> Allow log event to be created using the builder pattern.
> --------------------------------------------------------
>
> Key: LOG4J2-2639
> URL: https://issues.apache.org/jira/browse/LOG4J2-2639
> Project: Log4j 2
> Issue Type: Task
> Components: API
> Affects Versions: 3.0.0
> Reporter: Ralph Goers
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In some cases it would be convenient to create log events using a builder
> pattern. One advantage of this approach is that it would allow the location
> information to be more easily provided.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
