rpuch commented on code in PR #7729:
URL: https://github.com/apache/ignite-3/pull/7729#discussion_r2903797564
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java:
##########
@@ -1409,4 +1409,8 @@ CompletableFuture<Void> sendCompactionCommand(long
compactionRevision) {
public void markAsStopping() {
metaStorageSvcFut.thenAccept(MetaStorageServiceImpl::markAsStopping);
}
+
+ public Executor watchExecutor() {
Review Comment:
Interfaces should be as clear and succinct as possible. Ability to get the
WatchExecutor is a technical detail, and putting it on the interface would make
the interface worse for no good reason. Doing so will simply not improve
anything, regardless of whether before the refactoring or after it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
