rpuch commented on code in PR #7729:
URL: https://github.com/apache/ignite-3/pull/7729#discussion_r2903678679
##########
modules/runner/src/main/java/org/apache/ignite/internal/schema/SchemaSafeTimeTrackerImpl.java:
##########
@@ -74,16 +78,16 @@ public void onEnqueued(CompletableFuture<Void>
newNotificationFuture, List<Entry
// The update touches the Catalog (i.e. schemas), so we must
chain with the core notification future
// as Catalog listeners will be included in it (because we
need to wait for those listeners to finish execution
// before updating the schema safe time).
- newSchemaSafeTimeUpdateFuture =
schemaSafeTimeUpdateFuture.thenCompose(unused -> newNotificationFuture);
+ newSchemaSafeTimeUpdateFuture =
schemaSafeTimeUpdateFuture.thenComposeAsync(unused -> newNotificationFuture,
watchExecutor);
Review Comment:
Watch executor uses `DiscardPolicy`, so the future will just hang, but this
will not cause any problems as the tracker itself will be closed and complete
all waiting futures with `NodeStoppingException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
