chrisrueger commented on PR #79:
URL: https://github.com/apache/freemarker/pull/79#issuecomment-1868098656
Quick feedback.
I built locally with gradle.
I added this to `settings.gradle.kts`
```
plugins {
id("org.gradle.toolchains.foojay-resolver-convention") version "0.7.0"
}
```
as described here
https://docs.gradle.org/current/userguide/toolchains.html#sub:download_repositories
which automatically downloads the required JDKs. I did not have JDK16
installed so the build failed initially. This plugin made it work
automatically. Just as an idea to make it build right away without manual
intervention.
Furthermore I installed built `freemarker-gae-2.3.33-SNAPSHOT.jar` into our
OSGi environment and ran testcases successfully. So now regression on the part
covered in our tests.
Conclusion: 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
