ddekany commented on PR #79:
URL: https://github.com/apache/freemarker/pull/79#issuecomment-1865285824
It's of course better that here we build with real JDK 8 (except core16,
obviously).
The javadoc we are using is from JDK 8 currently, but it should be the JDK
16 one (that has the search field, etc.).
Signing: Not sure how people enter/store safely their private key password
(like maybe have a `gradle.properties` on encrypted folder), but the easiest
way I have found is just using `gpg` (it pops up a password enry window), so I
suggest adding this:
```
if (hasProperty("useGpgCmd")) {
signing {
useGpgCmd()
}
}
```
(Haven't tested publishing to the Apache Maven repo yet. That also will get
the extra credentials from somewhere. Will see...)
Some minimal comments/explanation here and there would be good. Like tt's a
quite tricky build with the "fake" subprojects for example. Also, in the 3
branch I had commands about the Serlvet/JSP stesting dependencies, that weren't
copied over.
The build section of the README.md needs to be updated. I can do it after
merge, or maybe you want to provide some information youself there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
