nickva commented on code in PR #5351:
URL: https://github.com/apache/couchdb/pull/5351#discussion_r1873770291
##########
src/chttpd/src/chttpd_node.erl:
##########
@@ -74,7 +86,9 @@ handle_node_req(#httpd{method = 'GET', path_parts = [_,
_Node, <<"_versions">>]}
collator_version => couch_util:version_to_binary(ColVer)
},
javascript_engine => JsEngine
- });
+ },
+ Response = maps:merge(BaseResponse, SearchResponse),
Review Comment:
> I thought about it, but yeah I felt it was more consistent that way. Also,
if we change our mind about exposing nouveau's version here, there is less to
change
Hmm, looking at it again I think we have two cases:
1) `"$type": {"name":"$name", "version":"$ver"}` if we could swap out
alternatives. We can swap the js engine, and potentially link against a
different icu collation library (maybe a built-in one in erlang or something)).
2) `"$name":{"version":"$ver"}` for components which we'd likely never swap
for alternatives, like Erlang.
So I think clouseau fits more in the second category. Especially if we
already have a new search component nouveau, and it fits the second category.
It doesn't replace clouseau but works in parallel with it.
Now, as a future enhancement, it could make sense exposing the lucene, java
versions used. But in that case it would also make sense to make it `{...,
"clouseau": {...}, "nouveau": {},...}` as one could use them in parallel
potentially.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
