nickva commented on code in PR #5351:
URL: https://github.com/apache/couchdb/pull/5351#discussion_r1872811124
##########
src/chttpd/src/chttpd_node.erl:
##########
@@ -74,7 +86,9 @@ handle_node_req(#httpd{method = 'GET', path_parts = [_,
_Node, <<"_versions">>]}
collator_version => couch_util:version_to_binary(ColVer)
},
javascript_engine => JsEngine
- });
+ },
+ Response = maps:merge(BaseResponse, SearchResponse),
Review Comment:
Having a “search” section kinda implies we could have a different name there
besides “clouseau”. But if, say, we enable nouveau, it’s still going to report
clouseau as the search component if it can ping it.
Since it’s really only about clouseau might be simpler to just call the
section “clouseau”? Or maybe this way it’s more consistent with how other
entries look …?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
