nickva commented on code in PR #5213:
URL: https://github.com/apache/couchdb/pull/5213#discussion_r1744027266
##########
src/rexi/src/rexi_utils.erl:
##########
@@ -95,6 +107,49 @@ process_message(RefList, Keypos, Fun, Acc0, TimeoutRef,
PerMsgTO) ->
end;
{rexi_DOWN, _, _, _} = Msg ->
Fun(Msg, nil, Acc0)
- after PerMsgTO ->
- {timeout, Acc0}
+ end.
+
+add_delta({A}, Delta) -> {A, Delta};
+add_delta({A, B}, Delta) -> {A, B, Delta};
+add_delta({A, B, C}, Delta) -> {A, B, C, Delta};
+add_delta({A, B, C, D}, Delta) -> {A, B, C, D, Delta};
+add_delta({A, B, C, D, E}, Delta) -> {A, B, C, D, E, Delta};
+add_delta({A, B, C, D, E, F}, Delta) -> {A, B, C, D, E, F, Delta};
+add_delta({A, B, C, D, E, F, G}, Delta) -> {A, B, C, D, E, F, G, Delta};
Review Comment:
At first sight this looks a bit awkward. Do we have any `add_delta({A, B, C,
D, E, F}, Delta) -> {A, B, C, D, E, F, Delta};` message sent to rexi?
It might be better to be explicit about what message rexi will actually get.
We may have to do a two-stage PRs. One to prep the receivers to accept both old
and new patterns, then another one to start sending the new messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
