nickva commented on code in PR #5213:
URL: https://github.com/apache/couchdb/pull/5213#discussion_r1744023860
##########
src/rexi/src/rexi_utils.erl:
##########
@@ -60,6 +62,16 @@ process_mailbox(RefList, Keypos, Fun, Acc0, TimeoutRef,
PerMsgTO) ->
process_message(RefList, Keypos, Fun, Acc0, TimeoutRef, PerMsgTO) ->
receive
+ Msg ->
Review Comment:
This changes the rexi message receive pattern by accepting all messages,
while previously we left unknown ones in the mailbox. We may crash in `case
Payload` if we get an unknown message, while previously we left it in the
mailbox.
It might be better if we explicitly receive only the messages we expect and
not all of them. That was actually the impetus for `{rexi, ...}` message
patterns. There we bugs related to rexi utils receiving 2 items tuples and
ignoring them. That effort only went half-way by adding clauses to receive here
but nowhere else. Perhaps we can resurrect it and enhance those {rexi, ... }
message to take an extra map with options where delta or other context can do
into?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
