nickva commented on code in PR #5181:
URL: https://github.com/apache/couchdb/pull/5181#discussion_r1725168189
##########
src/couch/test/eunit/couch_key_tree_tests.erl:
##########
@@ -561,10 +561,15 @@ should_not_use_excessive_memory_when_stemming() ->
% Without the optimization #91de482fd66f4773b3b8583039c6bcaf1c5727ec
% stemming would consume about 18_000_000 words. With it, it consumes
% 6_000_000. So, use 13_000_000 as a threshold.
+ Size =
+ case ?COUCHDB_JS_ENGINE of
+ "quickjs" -> 18_000_000;
+ "spidermonkey" -> 21_000_000
Review Comment:
I pulled the tree generation into a separate module and see that in 27 the
sizes of a tree is slightly larger
27
```
erts_debug:size(x:tree()).
2052613
```
26
```
erts_debug:flat_size(x:tree()).
1759383
```
This coupled with an odd dependency on js engines, even though the key tree
has nothing to do with js engines, indicates this is too flaky to deal with. It
was a nice hack while it lasted, but I'd opt to remove the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
