jiahuili430 commented on code in PR #5181:
URL: https://github.com/apache/couchdb/pull/5181#discussion_r1724125252
##########
src/couch/test/eunit/couch_key_tree_tests.erl:
##########
@@ -561,10 +561,15 @@ should_not_use_excessive_memory_when_stemming() ->
% Without the optimization #91de482fd66f4773b3b8583039c6bcaf1c5727ec
% stemming would consume about 18_000_000 words. With it, it consumes
% 6_000_000. So, use 13_000_000 as a threshold.
+ Size =
+ case ?COUCHDB_JS_ENGINE of
+ "quickjs" -> 18_000_000;
+ "spidermonkey" -> 21_000_000
Review Comment:
Yes, quickjs is always smaller than spidermonkey 1.8.5.
- If I run tests using `make eunit apps=couch suites=couch_key_tree_tests
tests=key_tree_stemming_test_`, then `quickjs -> 18_000_000, spidermonkey ->
21_000_000`;
- If using `make eunit`, they use more heap, `quickjs -> 19_000_000,
spidermonkey -> 22_000_000`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
