nickva commented on code in PR #37: URL: https://github.com/apache/couchdb-glazier/pull/37#discussion_r1719021318
########## bin/variables.ps1: ########## @@ -10,38 +10,44 @@ # License for the specific language governing permissions and limitations under # the License. +# Installation directory for build tools +$toolsDir = "C:\tools" + # VCPKG SETTINGS # Download location of Vcpkg for Windows -$vcpkgVersion = "2023.10.19" +$vcpkgVersion = "2024.07.12" $vcpkgUri = "https://github.com/microsoft/vcpkg/archive/refs/tags/${vcpkgVersion}.zip"; $vcpkgFile = Split-Path $vcpkgUri -Leaf -$vcpkgInstallPath = "C:\tools\vcpkg" +$vcpkgInstallPath = "${toolsDir}\vcpkg" $vcpkgBase = "${vcpkgInstallPath}\installed\x64-windows" # ERLANG BUILD SETTINGS # Download location of the Erlang/OTP Environment for Windows (x64) -$erlVersion = "25.3.2.12" +$erlVersion = "25.3.2.13" $erlBuildUri = "https://github.com/erlang/otp/releases/download/OTP-${erlVersion}/otp_win64_${erlVersion}.exe"; $erlBuildFile = Split-Path $erlBuildUri -Leaf $erlDir = "erl-${erlVersion}" -$erlInstallPath = "C:\tools\${erlDir}" +$erlInstallPath = "${toolsDir}\${erlDir}" # ERLANG BUILD SETTINGS # Download location of the Elixir binaries for Windows (x64) -$elxBuildUri = "https://github.com/elixir-lang/elixir/releases/download/v1.15.7/elixir-otp-25.zip"; +$elxVersion = "1.15.7" +$elxBuildUri = "https://github.com/elixir-lang/elixir/releases/download/v${elxVersion}/elixir-otp-25.zip"; $elxBuildFile = Split-Path $elxBuildUri -Leaf -$elxInstallPath = "C:\relax\elixir" +$elxDir = "elixir-${elxVersion}" +$elxInstallPath = "${toolsDir}\${elxDir}" # SPIDERMONKEY SETTINGS -# Donwload location of the SpiderMonkey development files for Windows (x64) +# Download location of the pre-build SpiderMonkey development files for Windows (x64) $smBuild = "Windows-mozjs-91" -$smBuildUri = "https://github.com/big-r81/couchdb-sm/releases/download/v0.0.3/$smBuild.tar.xz"; +$smBuildVersion = "0.0.5" +$smBuildUri = "https://github.com/big-r81/couchdb-sm/releases/download/v${smBuildVersion}/${smBuild}.tar.xz"; $smBuildFile = Split-Path $smBuildUri -Leaf -$smInstallPath = "C:\relax\vcpkg\installed\x64-windows" +$smInstallPath = "${vcpkgBase}" Review Comment: good catch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
