nickva commented on code in PR #5160:
URL: https://github.com/apache/couchdb/pull/5160#discussion_r1702079058
##########
src/couch_replicator/src/couch_replicator_fabric.erl:
##########
@@ -34,14 +34,8 @@ docs(DbName, Options, QueryArgs, Callback, Acc) ->
after
fabric_streams:cleanup(Workers)
end;
- {timeout, NewState} ->
- DefunctWorkers = fabric_util:remove_done_workers(
- NewState#stream_acc.workers, waiting
- ),
- fabric_util:log_timeout(
- DefunctWorkers,
- "replicator docs"
- ),
+ {timeout, DefunctWorkers} ->
+ fabric_util:log_timeout(DefunctWorkers, "replicator docs"),
Review Comment:
I was surprised as well. I wonder if we had enforced an 80 columns things
before and now we don't (or erlfmt changed). But thought it is a decent
cleanup. Probably there are other cases we can prettify a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
