jaydoane commented on code in PR #5160:
URL: https://github.com/apache/couchdb/pull/5160#discussion_r1702039786
##########
src/fabric/src/fabric_streams.erl:
##########
@@ -165,10 +177,7 @@ handle_stream_start(rexi_STREAM_INIT, {Worker, From}, St)
->
{stop, St#stream_acc{workers = [], ready = Ready1}}
end
end;
-handle_stream_start({ok, Error}, _, St) when Error == ddoc_updated; Error ==
insufficient_storage ->
- WaitingWorkers = [W || {W, _} <- St#stream_acc.workers],
- ReadyWorkers = [W || {W, _} <- St#stream_acc.ready],
- cleanup(WaitingWorkers ++ ReadyWorkers),
Review Comment:
Is this cleanup no longer necessary because of the new `cleanup(Workers0)`
in the above `Else` clause?
##########
src/couch_replicator/src/couch_replicator_fabric.erl:
##########
@@ -34,14 +34,8 @@ docs(DbName, Options, QueryArgs, Callback, Acc) ->
after
fabric_streams:cleanup(Workers)
end;
- {timeout, NewState} ->
- DefunctWorkers = fabric_util:remove_done_workers(
- NewState#stream_acc.workers, waiting
- ),
- fabric_util:log_timeout(
- DefunctWorkers,
- "replicator docs"
- ),
+ {timeout, DefunctWorkers} ->
+ fabric_util:log_timeout(DefunctWorkers, "replicator docs"),
Review Comment:
Not a big deal, but it's curious that erlfmt is fine with this on a single
line now, but before it took 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
