jaydoane commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1587027700
##########
test/elixir/test/view_errors_test.exs:
##########
@@ -190,7 +190,12 @@ defmodule ViewErrorsTest do
# fires first. The first timeout is the couch_os_process
# waiting for data back from couchjs. The second is the
# gen_server call to couch_os_process.
- assert resp.body["error"] == "os_process_error" or resp.body["error"] ==
"timeout"
+ err_name = resp.body["error"]
+ assert (
+ err_name == "os_process_error" or
+ err_name == "timeout" or
+ err_name == "InternalError"
+ )
Review Comment:
what do you think of the more succinct (and untested)
`assert Enum.member?("os_process_error", "timeout", "InternalErrror",
err_name)`
?
##########
src/couch_quickjs/test/couch_quickjs_tests.erl:
##########
@@ -0,0 +1,71 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you may not
+% use this file except in compliance with the License. You may obtain a copy of
+% the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing, software
+% distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+% WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+% License for the specific language governing permissions and limitations under
+% the License.
+
+-module(couch_quickjs_tests).
+
+-include_lib("couch/include/couch_eunit.hrl").
+
+setup() ->
+ Ctx = test_util:start_couch(),
+ Ctx.
Review Comment:
Is this line redundant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
