nickva commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1591263357


##########
src/chttpd/src/chttpd_node.erl:
##########
@@ -51,6 +51,17 @@ handle_node_req(#httpd{method = 'GET', path_parts = [_, 
_Node, <<"_versions">>]}
     UcaVer = couch_ejson_compare:get_uca_version(),
     ColVer = couch_ejson_compare:get_collator_version(),
     Hashes = crypto:supports(hashs),
+    EngineName = couch_server:get_js_engine(),
+    JsEngine =
+        case EngineName of
+            <<"spidermonkey">> ->
+                #{
+                    name => EngineName,
+                    version => couch_server:get_spidermonkey_version()
+                };
+            _Other ->
+                #{name => EngineName}

Review Comment:
   Unfortunately the VERSION file is not installed in the release and it seems 
hardly worth it adding more code for shuffling it into a release since VERSION 
is in sync with CouchDB version anyway.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to