>From Ian Maxon <[email protected]>: Attention is currently required from: Michael Blow.
Ian Maxon has posted comments on this change by Ian Maxon. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20280?usp=email ) Change subject: [ASTERIXDB-3640][TEST]Use s3mock in testcontainers ...................................................................... Patch Set 23: (2 comments) File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/cloud_storage/CloudStorageAzTest.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20280/comment/0cbc1c12_bc76c9a5?usp=email : PS23, Line 124: && !S3_ONLY.equals(getText(cu.get(0).getDescription())))); > ```suggestion […] i think it should work like this, it just has to be the in the first compilation unit. i can extend it in the azure one to work for matching the text in any compilation unit in the suite File asterixdb/asterix-app/src/test/resources/runtimets/testsuite_cloud_storage.xml: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20280/comment/26c8d727_566b7a46?usp=email : PS23, Line 79: <description>S3Only</description> > interesting- I was thinking about some solution like this- I wonder if we > should have some ability t […] let me see if there's a neater way to do it in the xsd that produces this class and xml. i kanged this approach from what Hussain added for some of the external data suites. certainly being able to enforce environmental requirements on certain tests without having to chop up or duplicate the suites would be nice to have -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20280?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: Iad1a6f9331fd844f3e3c04b8f56e811e4117f83a Gerrit-Change-Number: 20280 Gerrit-PatchSet: 23 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Thu, 02 Oct 2025 19:25:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Blow <[email protected]>
