>From Michael Blow <[email protected]>: Attention is currently required from: Ian Maxon.
Michael Blow has posted comments on this change by Ian Maxon. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20280?usp=email ) Change subject: [ASTERIXDB-3640][TEST]Use s3mock in testcontainers ...................................................................... Patch Set 23: Code-Review+2 (2 comments) File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/cloud_storage/CloudStorageAzTest.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20280/comment/ee4f7a24_1009e06e?usp=email : PS23, Line 124: && !S3_ONLY.equals(getText(cu.get(0).getDescription())))); ```suggestion && !getText(cu.get(0).getDescription()).contains(S3_ONLY))); ``` could we do something like this, to allow multiple keywords in the description? Same in the other place(s) we do this... File asterixdb/asterix-app/src/test/resources/runtimets/testsuite_cloud_storage.xml: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20280/comment/cc16a637_580e3d8c?usp=email : PS23, Line 79: <description>S3Only</description> interesting- I was thinking about some solution like this- I wonder if we should have some ability to add arbitrary attributes in the event we need additional ones. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20280?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: Iad1a6f9331fd844f3e3c04b8f56e811e4117f83a Gerrit-Change-Number: 20280 Gerrit-PatchSet: 23 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Comment-Date: Thu, 02 Oct 2025 18:53:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
