>From Ali Alsuliman <[email protected]>: Attention is currently required from: Murtadha Hubail, Peeyush Gupta. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20293 )
Change subject: [NO ISSUE][RT] Notify joblet cleanup if joblet creation fails ...................................................................... Patch Set 1: (1 comment) File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20293/comment/25c67d7d_ab3db926 PS1, Line 212: ncs.getClusterController(jobId.getCcId()).notifyJobletCleanup(jobId, ncs.getId()); I think there are few problems doing it this way. I believe the joblet cleanup notification could possibly be sent before the NotifyTaskFailureWork is scheduled to run. I think if that happens then in the CC the run.getCleanupPendingNodeIds() may not yet have pending node IDs. I think what we should do is in the AbortTasksWork, if there is no joblet, then the NC schedules a CleanupJobletWork. I believe CleanupJobletWork already assumes/handles the case where the joblet could be null (we should just double check). CleanupJobletWork also does some cleanup that we might have missed if we only do notifyJobletCleanup. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20293 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I13ee5535269c5152a1cd923502a013fa4fad0b40 Gerrit-Change-Number: 20293 Gerrit-PatchSet: 1 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Comment-Date: Fri, 05 Sep 2025 00:40:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
