>From Peeyush Gupta <[email protected]>: Attention is currently required from: Murtadha Hubail, Ali Alsuliman. Peeyush Gupta has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20293 )
Change subject: [NO ISSUE][RT] Notify joblet cleanup if joblet creation fails ...................................................................... Patch Set 2: (1 comment) File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20293/comment/a0b5595b_ebc0cc57 PS1, Line 212: ncs.getClusterController(jobId.getCcId()).notifyJobletCleanup(jobId, ncs.getId()); > I think there are few problems doing it this way. […] `CleanupJobletWork` does not currently handle joblet being null. It was actually scheduled via CC but was not able to send cleanup complete notification due to joblet being null. In the new patch, I have created another scheduled work called `FailedJobletCreationCleanupWork` that sends cleanup complete notification to the CC irrespective of joblet being null. I am scheduling it in `StartTasksWork` after the `NotifyTaskFailureWork` is scheduled to run. I did not add it to `AbortTasksWork` as I was not sure if there joblet can be null because of some reason other than joblet creation itself was failed. Maybe `CleanupJobletWork` was already run on it. Let me know if you think it should still be scheduled in `AbortTasksWork` -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20293 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I13ee5535269c5152a1cd923502a013fa4fad0b40 Gerrit-Change-Number: 20293 Gerrit-PatchSet: 2 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Fri, 05 Sep 2025 01:46:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
