>From Ali Alsuliman <[email protected]>: Attention is currently required from: Murtadha Hubail, Peeyush Gupta. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20293 )
Change subject: [NO ISSUE][RT] Notify joblet cleanup if joblet creation fails ...................................................................... Patch Set 3: (2 comments) File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/FailedJobletCreationCleanupWork.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20293/comment/e4acdbea_02c204d2 PS3, Line 45: ncs.getClusterController(jobId.getCcId()).notifyJobletCleanup(jobId, ncs.getId()); Can we also call ncs.removeJobParameterByteStore(jobId)? File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20293/comment/687724bd_46cb8f91 PS1, Line 212: ncs.getClusterController(jobId.getCcId()).notifyJobletCleanup(jobId, ncs.getId()); > `CleanupJobletWork` does not currently handle joblet being null. […] Scheduling 'FailedJobletCreationCleanupWork' in 'StartTasksWork' should be fine. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20293 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: I13ee5535269c5152a1cd923502a013fa4fad0b40 Gerrit-Change-Number: 20293 Gerrit-PatchSet: 3 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Comment-Date: Fri, 05 Sep 2025 15:32:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peeyush Gupta <[email protected]> Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
