>From Peeyush Gupta <[email protected]>:

Attention is currently required from: Murtadha Hubail, Ali Alsuliman.
Peeyush Gupta has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20293 )

Change subject: [NO ISSUE][RT] Notify joblet cleanup if joblet creation fails
......................................................................


Patch Set 4:

(2 comments)

File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/FailedJobletCreationCleanupWork.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20293/comment/8541b7d1_0439b428
PS3, Line 45: 
ncs.getClusterController(jobId.getCcId()).notifyJobletCleanup(jobId, 
ncs.getId());
> Can we also call ncs. […]
Done


File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20293/comment/be510144_4bf1d951
PS1, Line 212: 
ncs.getClusterController(jobId.getCcId()).notifyJobletCleanup(jobId, 
ncs.getId());
> Scheduling 'FailedJobletCreationCleanupWork' in 'StartTasksWork' should be 
> fine.
Ack



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20293
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: I13ee5535269c5152a1cd923502a013fa4fad0b40
Gerrit-Change-Number: 20293
Gerrit-PatchSet: 4
Gerrit-Owner: Peeyush Gupta <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-CC: Michael Blow <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Comment-Date: Fri, 05 Sep 2025 15:44:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peeyush Gupta <[email protected]>
Comment-In-Reply-To: Ali Alsuliman <[email protected]>
Gerrit-MessageType: comment

Reply via email to