membphis commented on code in PR #12375:
URL: https://github.com/apache/apisix/pull/12375#discussion_r2165267903
##########
apisix/cli/etcd.lua:
##########
@@ -379,6 +379,10 @@ function _M.init(env, args)
util.die("the etcd cluster needs at least 50% and above healthy
nodes\n")
end
+ if yaml_conf.deployment.role == "data_plane" then
Review Comment:
@SkyeYoung add some comments, to tell other delevelopers about why we
`return true` directly
##########
apisix/cli/etcd.lua:
##########
@@ -379,6 +379,10 @@ function _M.init(env, args)
util.die("the etcd cluster needs at least 50% and above healthy
nodes\n")
end
+ if yaml_conf.deployment.role == "data_plane" then
Review Comment:
and we can write some error log(info or debug level)
then it can be verified in your test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
