SkyeYoung commented on code in PR #12375:
URL: https://github.com/apache/apisix/pull/12375#discussion_r2163347345


##########
apisix/cli/etcd.lua:
##########
@@ -379,6 +379,10 @@ function _M.init(env, args)
         util.die("the etcd cluster needs at least 50% and above healthy 
nodes\n")
     end
 
+    if yaml_conf.deployment.role == "data_plane" then

Review Comment:
   Because yaml_conf has already been parsed above and there are similar checks 
already in place, I've chosen to put it here instead of adding it to the 
`init_etcd` function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to