meatballspaghetti commented on code in PR #5451:
URL: https://github.com/apache/accumulo/pull/5451#discussion_r2047391019
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/create/PopulateZookeeper.java:
##########
@@ -53,24 +53,23 @@ public Repo<Manager> call(FateId fateId, Manager manager)
throws Exception {
Utils.getTableNameLock().lock();
try {
- // write tableName & tableId to zookeeper
- Utils.checkTableNameDoesNotExist(manager.getContext(),
tableInfo.getTableName(),
- tableInfo.getNamespaceId(), tableInfo.getTableId(),
TableOperation.CREATE);
-
+ var context = manager.getContext();
+ // write tableName & tableId, first to Table Mapping and then to
Zookeeper
+ context.getTableMapping(tableInfo.getNamespaceId()).put(context,
tableInfo.getTableId(),
Review Comment:
I handle removal of the table from the table mapping within
TableManager.removeTable, which is called by PopulateZookeeper.undo. So if an
exception is thrown here, it should call undo which will in turn delete both
the table and remove it from the mapping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
