cshannon commented on code in PR #5284:
URL: https://github.com/apache/accumulo/pull/5284#discussion_r1937124322
##########
server/manager/src/main/java/org/apache/accumulo/manager/ManagerClientServiceHandler.java:
##########
@@ -616,6 +620,54 @@ public void requestTabletHosting(TInfo tinfo, TCredentials
credentials, String t
manager.hostOndemand(Lists.transform(extents, KeyExtent::fromThrift));
}
+ @Override
+ public List<TKeyExtent> updateTabletMergeability(TInfo tinfo, TCredentials
credentials,
Review Comment:
I think the way it is now is fine because it already handles the empty case
pretty well. As you mentioned the calling code shouldn't ever hit the method
because the client checks it, but if for some reason that changed and an empty
map was submitted the server side I think it's fine because If splits are empty
then the for loop won't do anything and no conditional mutations will be
submitted or added so it just returns without doing anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
