DomGarguilo commented on code in PR #5284:
URL: https://github.com/apache/accumulo/pull/5284#discussion_r1930966079
##########
server/manager/src/main/java/org/apache/accumulo/manager/ManagerClientServiceHandler.java:
##########
@@ -616,6 +620,54 @@ public void requestTabletHosting(TInfo tinfo, TCredentials
credentials, String t
manager.hostOndemand(Lists.transform(extents, KeyExtent::fromThrift));
}
+ @Override
+ public List<TKeyExtent> updateTabletMergeability(TInfo tinfo, TCredentials
credentials,
Review Comment:
I wonder if it would be good to return early if splits is empty within this
method. I see that the calling code (`TableOperationsImpl`) also does this
check and avoids calling `updateTabletMergeability()` if `splits` is empty but
it might be good to add it here too so we don't have to rely on the calling
code to do that in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
