keith-turner commented on code in PR #5256:
URL: https://github.com/apache/accumulo/pull/5256#discussion_r1924122789
##########
core/src/main/java/org/apache/accumulo/core/fate/zookeeper/ZooCache.java:
##########
@@ -136,7 +166,9 @@ public void process(WatchedEvent event) {
clear();
break;
case SyncConnected:
- log.trace("{} ZooKeeper connection established, ignoring; {}",
cacheId, event);
+ log.trace("{} ZooKeeper connection established, re-establishing
watchers; {}",
Review Comment:
When a reconnect happens, we probably want to do the following in zoocache
1. Clear the cache
2. Add recursive watchers to zookeper
3. For successfully added watches, reset watchedPaths to only contain them.
Its important to reset watchedPaths because there could be exceptions adding
them back, so reseting watchedPaths helps deal with that issue. Was not sure
about clearing the cache, but it seems like a good thing to do because its not
really known why the reconnect is happening and if we will get an event from
the old zookeeper object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
