dlmarion commented on code in PR #5256:
URL: https://github.com/apache/accumulo/pull/5256#discussion_r1920682629
##########
server/base/src/main/java/org/apache/accumulo/server/security/handler/ZKPermHandler.java:
##########
@@ -468,22 +456,19 @@ private void createTablePerm(String user, TableId table,
Set<TablePermission> pe
*/
private void createNamespacePerm(String user, NamespaceId namespace,
Set<NamespacePermission> perms) throws KeeperException,
InterruptedException {
- synchronized (zooCache) {
Review Comment:
In some of the cases the code was calling ZooCache.clear(path), and in
others it was calling ZooCache.clear(). In all of the cases it seems to call
clear, then add something. It looks like all of the security classes that are
modified in this PR used the same pattern. I'm wondering if I might have to add
a Lock in each of the classes on which to synchronize on to preserve the
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
