DomGarguilo commented on code in PR #5250: URL: https://github.com/apache/accumulo/pull/5250#discussion_r1915589108
########## test/src/main/java/org/apache/accumulo/test/MaxWalReferencedIT.java: ########## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.test; + +import java.time.Duration; +import java.util.List; +import java.util.Map.Entry; +import java.util.SortedSet; +import java.util.TreeSet; +import java.util.UUID; +import java.util.concurrent.atomic.AtomicInteger; + +import org.apache.accumulo.core.client.Accumulo; +import org.apache.accumulo.core.client.AccumuloClient; +import org.apache.accumulo.core.client.BatchWriter; +import org.apache.accumulo.core.client.BatchWriterConfig; +import org.apache.accumulo.core.client.admin.NewTableConfiguration; +import org.apache.accumulo.core.conf.Property; +import org.apache.accumulo.core.data.Mutation; +import org.apache.accumulo.core.metadata.TServerInstance; +import org.apache.accumulo.miniclusterImpl.MiniAccumuloConfigImpl; +import org.apache.accumulo.server.ServerContext; +import org.apache.accumulo.server.log.WalStateManager; +import org.apache.accumulo.test.functional.ConfigurableMacBase; +import org.apache.accumulo.test.util.Wait; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.RawLocalFileSystem; +import org.apache.hadoop.io.Text; +import org.junit.jupiter.api.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Test that verifies the behavior of {@link Property#TSERV_WAL_MAX_REFERENCED}. + * <p> + * This test creates a table with splits and writes data in batches until the number of WALs in use + * exceeds the configured limit. It then waits for minor compactions to reduce the WAL count. + */ +public class MaxWalReferencedIT extends ConfigurableMacBase { + private static final Logger log = LoggerFactory.getLogger(MaxWalReferencedIT.class); + + final int WAL_MAX_REFERENCED = 3; + + @Override + protected Duration defaultTimeout() { + return Duration.ofMinutes(4); + } + + @Override + protected void configure(MiniAccumuloConfigImpl cfg, Configuration hadoopCoreSite) { + final String hdfsMinBlockSize = "1048576"; + + // Set a small WAL size so we roll frequently + cfg.setProperty(Property.TSERV_WAL_MAX_SIZE, hdfsMinBlockSize); + // Set the max number of WALs that can be referenced + cfg.setProperty(Property.TSERV_WAL_MAX_REFERENCED, Integer.toString(WAL_MAX_REFERENCED)); + cfg.setNumTservers(1); Review Comment: Added in 449e457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
