Hi Qiufang, Thank you for the review.
https://datatracker.ietf.org/doc/draft-ietf-netmod-acl-extensions/07/ takes these comments into account. Please see some clarifications below. Cheers, Med > -----Message d'origine----- > De : netmod <[email protected]> De la part de maqiufang (A) > Envoyé : lundi 6 mai 2024 11:22 > À : Lou Berger <[email protected]> > Cc : [email protected] > Objet : Re: [netmod] WG Last Call: draft-ietf-netmod-acl- > extensions-06 > > > Hi, Lou, all, > > I've reviewed this document and believe it is ready for > publication. Some comments/nits that should be fixed before > publication: > > - Sec.1.1 Why are the IANA-Maintained Modules provided in A.2, > B.2 and C.2 being asked to be removed from the final RFC? [Med] Yes, only the templates will be maintained. Should > the editor then also remove the second paragraph of abstract (The > document also defines IANA-maintained modules for ICMP types and > IPv6 extension headers)? [Med] No. Did I miss something? [Med] This approach is compliant with what is documented in the 8407bis. You may see, e.g., RFC 9108. > > - Sec.3.4 "The augmented ACL structure (Figure 1) includes a new > leaf 'flags-bitmask' to better handle TCP flags [RFC9293]." > The "flags-bitmask" is defined as container, rather than leaf. > [Med] ACK > - Sec.3.5 " The augmented ACL structure (Figure 1) includes a new > leaf 'fragment' to better handle fragments." > I cannot find a leaf node named "fragment", maybe you are > referring to "ipv4-fragment" and "ipv6-fragment"? Likewise, they > are defined as containers. [Med] ACK. > > - Sec.4, the YANG module > - copyright years should be 2024 > - s/Top-levl/Top-level/ > - Following the guidelines in rfc8407bis, leaf-list/list > identifier SHOULD be singular. Inside the icmpv4/6-type-set list, > the list identifier "types" may need to rename as "type", and > then change the name of the key. > [Med] Good catches. Fixed. > - Appendix A.2 title: s/Initial Version of the The ICMPv4 Types > IANA-Maintained Module/Initial Version of the ICMPv4 Types IANA- > Maintained Module/ (remove "The") [Med] ACK > > - Appendix B.2 title: s/Initial Version of the The ICMPv6 Types > IANA-Maintained Module/Initial Version of the ICMPv6 Types IANA- > Maintained/ (remove "The") [Med] ACK > > - Appendix C.2 file "[email protected] " name > doesn't match the revision-date 2023-09-29 > [Med] Fixed. > - Appendix E. the JSON examples don't seem valid, e.g., > - s/ "acl-enh:flags-bitmask":{/ "ietf-acl-enh:flags-bitmask":{/ > - s/ "ietf-acces-control-list:acls":{/ "ietf-access-control- > list:acls":{/ (typo "acces") > - s/ "forwarding":"ietf-acces-control-list:accept"/ > "forwarding":"ietf-access-control-list:accept"/ (typo "acces") > [Med] Fixed, thanks. > Best Regards, > Qiufang > > -----Original Message----- > From: netmod [mailto:[email protected]] On Behalf Of Lou > Berger > Sent: Tuesday, April 30, 2024 5:42 AM > To: NETMOD Group <[email protected]> > Cc: NetMod WG Chairs <[email protected]> > Subject: [netmod] WG Last Call: draft-ietf-netmod-acl-extensions- > 06 > > All, > > This starts working group last call on > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2 > Fdatatracker.ietf.org%2Fdoc%2Fdraft-ietf-netmod-acl- > extensions%2F&data=05%7C02%7Cmohamed.boucadair%40orange.com%7C62e > 327e2dc7041160e8608dc6dae0c47%7C90c7a20af34b40bfbc48b9253b6f5d20% > 7C0%7C0%7C638505841511444084%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4w > LjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C% > 7C&sdata=KW1HJMujcV%2BqRmUifCIngY7s8O5PKtVK3Q2HO7supZY%3D&reserve > d=0 > > The working group last call ends on May 13th. > Please send your comments to the working group mailing list. > > Positive comments, e.g., "I've reviewed this document and believe > it is ready for publication", are welcome! > This is useful and important, even from authors. > > Thank you, > Lou (Co-Chair & doc Shepherd) > > > _______________________________________________ > netmod mailing list > [email protected] > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2 > Fwww.ietf.org%2Fmailman%2Flistinfo%2Fnetmod&data=05%7C02%7Cmohame > d.boucadair%40orange.com%7C62e327e2dc7041160e8608dc6dae0c47%7C90c > 7a20af34b40bfbc48b9253b6f5d20%7C0%7C0%7C638505841511456096%7CUnkn > own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1 > haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=Lhe6FKjEDxkQKVNIHOuAR%2Fin > VYShS3bAd2D5nIwni24%3D&reserved=0 > > _______________________________________________ > netmod mailing list > [email protected] > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2 > Fwww.ietf.org%2Fmailman%2Flistinfo%2Fnetmod&data=05%7C02%7Cmohame > d.boucadair%40orange.com%7C62e327e2dc7041160e8608dc6dae0c47%7C90c > 7a20af34b40bfbc48b9253b6f5d20%7C0%7C0%7C638505841511464477%7CUnkn > own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1 > haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=MHbyuKLW3xOcrhi8uJGg1lmMrv > dIvrfRCi7f0svpy3Y%3D&reserved=0 ____________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you. _______________________________________________ netmod mailing list -- [email protected] To unsubscribe send an email to [email protected]
