Hi, Lou, all, I've reviewed this document and believe it is ready for publication. Some comments/nits that should be fixed before publication:
- Sec.1.1 Why are the IANA-Maintained Modules provided in A.2, B.2 and C.2 being asked to be removed from the final RFC? Should the editor then also remove the second paragraph of abstract (The document also defines IANA-maintained modules for ICMP types and IPv6 extension headers)? Did I miss something? - Sec.3.4 "The augmented ACL structure (Figure 1) includes a new leaf 'flags-bitmask' to better handle TCP flags [RFC9293]." The "flags-bitmask" is defined as container, rather than leaf. - Sec.3.5 " The augmented ACL structure (Figure 1) includes a new leaf 'fragment' to better handle fragments." I cannot find a leaf node named "fragment", maybe you are referring to "ipv4-fragment" and "ipv6-fragment"? Likewise, they are defined as containers. - Sec.4, the YANG module - copyright years should be 2024 - s/Top-levl/Top-level/ - Following the guidelines in rfc8407bis, leaf-list/list identifier SHOULD be singular. Inside the icmpv4/6-type-set list, the list identifier "types" may need to rename as "type", and then change the name of the key. - Appendix A.2 title: s/Initial Version of the The ICMPv4 Types IANA-Maintained Module/Initial Version of the ICMPv4 Types IANA-Maintained Module/ (remove "The") - Appendix B.2 title: s/Initial Version of the The ICMPv6 Types IANA-Maintained Module/Initial Version of the ICMPv6 Types IANA-Maintained/ (remove "The") - Appendix C.2 file "[email protected] " name doesn't match the revision-date 2023-09-29 - Appendix E. the JSON examples don't seem valid, e.g., - s/ "acl-enh:flags-bitmask":{/ "ietf-acl-enh:flags-bitmask":{/ - s/ "ietf-acces-control-list:acls":{/ "ietf-access-control-list:acls":{/ (typo "acces") - s/ "forwarding":"ietf-acces-control-list:accept"/ "forwarding":"ietf-access-control-list:accept"/ (typo "acces") Best Regards, Qiufang -----Original Message----- From: netmod [mailto:[email protected]] On Behalf Of Lou Berger Sent: Tuesday, April 30, 2024 5:42 AM To: NETMOD Group <[email protected]> Cc: NetMod WG Chairs <[email protected]> Subject: [netmod] WG Last Call: draft-ietf-netmod-acl-extensions-06 All, This starts working group last call on https://datatracker.ietf.org/doc/draft-ietf-netmod-acl-extensions/ The working group last call ends on May 13th. Please send your comments to the working group mailing list. Positive comments, e.g., "I've reviewed this document and believe it is ready for publication", are welcome! This is useful and important, even from authors. Thank you, Lou (Co-Chair & doc Shepherd) _______________________________________________ netmod mailing list [email protected] https://www.ietf.org/mailman/listinfo/netmod _______________________________________________ netmod mailing list [email protected] https://www.ietf.org/mailman/listinfo/netmod
