Re: [PATCH net-next 1/8] net/flower: Introduce hardware offload support

[Amir Vadai]

On Tue, Mar 01, 2016 at 03:53:44PM +0100, Jiri Pirko wrote:
> Tue, Mar 01, 2016 at 03:24:43PM CET, a...@vadai.me wrote:
> >This patch is based on a patch made by John Fastabend.
> >It adds support for offloading cls_flower.
> >A filter that is offloaded successfuly by hardware, will not be added to
> >the hashtable and won't be processed by software.
> >
> 
> <snip>
> 
> >+enum {
> >+    TC_CLSFLOWER_REPLACE,
> >+    TC_CLSFLOWER_DESTROY,
> >+};
> 
> Name this enum
Right,
Thanks

> 
> >+
> >+struct tc_cls_flower_offload {
> >+    int command;
> 
>         ^^^ and use it here
> 
> >+    u64 cookie;
> >+    struct flow_dissector *dissector;
> >+    struct fl_flow_key *mask;
> >+    struct fl_flow_key *key;
> >+    struct tcf_exts *exts;
> >+};