From: Saeed Mahameed <sae...@mellanox.com> Date: Wed, 24 Feb 2016 18:39:19 +0200
> From: Gal Pressman <g...@mellanox.com> > > Use dev->hw_features in vlan_hw_filter_capable instead of dev->features, > since dev->features can be turned on/off dynamically. > > Netdev features can be changed dynamically to off after vlan_vid_add > was called, thus vlan_vid_del will skip ndo_vlan_rx_kill_vid and will > leave the device driver with un-freed resources. Are you sure the fix isn't to make vlan_vid_add() check ->features instead of ->hw_features. Should we really be trying to add VLAN filters when the user has turned it off?
