Hi, Emil
Would you like to help me to make tests with this patch?
If the root cause is not the time span, I will make a new patch for this.
Thanks a lot.
Zhu Yanjun
On 01/07/2016 02:15 PM, zyjzyj2...@gmail.com wrote:
From: Zhu Yanjun <yanjun....@windriver.com>
In 802.3ad mode, the speed and duplex is needed. But in some NIC,
there is a time span between NIC up state and getting speed and duplex.
As such, sometimes a slave in 802.3ad mode is in up state without
speed and duplex. This will make bonding in 802.3ad mode can not
work well.
To make bonding driver be compatible with more NICs, it is
necessary to restrict the up state in 802.3ad mode.
Signed-off-by: Zhu Yanjun <yanjun....@windriver.com>
---
drivers/net/bonding/bond_main.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 09f8a48..7df8af5 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1991,6 +1991,17 @@ static int bond_miimon_inspect(struct bonding *bond)
link_state = bond_check_dev_link(bond, slave->dev, 0);
+ if ((BMSR_LSTATUS == link_state) &&
+ (BOND_MODE(bond) == BOND_MODE_8023AD)) {
+ rtnl_lock();
+ bond_update_speed_duplex(slave);
+ rtnl_unlock();
+ if ((slave->speed == SPEED_UNKNOWN) ||
+ (slave->duplex == DUPLEX_UNKNOWN)) {
+ link_state = 0;
+ netdev_info(bond->dev, "In 802.3ad mode, it is not
enough to up without speed and duplex");
+ }
+ }
switch (slave->link) {
case BOND_LINK_UP:
if (link_state)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
