Wed, Dec 02, 2015 at 12:27:09PM CET, niko...@cumulusnetworks.com wrote:
>On 12/01/2015 02:48 PM, Jiri Pirko wrote:
>> From: Jiri Pirko <j...@mellanox.com>
>> 
>> Similar to state notifications.
>> 
>> We allow caller to indicate if the notification should happen now or later,
>> depending on if he holds rtnl mutex or not. Introduce bond_slave_link_notify
>> function (similar to bond_slave_state_notify) which is later on called
>> with rtnl mutex and goes over slaves and executes delayed notification.
>> 
>> Signed-off-by: Jiri Pirko <j...@mellanox.com>
>> ---
>>  drivers/net/bonding/bond_main.c | 54 
>> +++++++++++++++++++++++++++--------------
>>  include/net/bonding.h           | 32 +++++++++++++++++++++---
>>  2 files changed, 65 insertions(+), 21 deletions(-)
>> 
>[snip]
>> diff --git a/include/net/bonding.h b/include/net/bonding.h
>> index c1740a2..50496ec 100644
>> --- a/include/net/bonding.h
>> +++ b/include/net/bonding.h
>> @@ -165,7 +165,8 @@ struct slave {
>>      u8     backup:1,   /* indicates backup slave. Value corresponds with
>>                            BOND_STATE_ACTIVE and BOND_STATE_BACKUP */
>>             inactive:1, /* indicates inactive slave */
>> -           should_notify:1; /* indicateds whether the state changed */
>> +           should_notify:1, /* indicateds whether the state changed */
>> +           should_notify_link:1; /* indicateds whether the link changed */
>
>s/indicateds/indicates/

will fix this c&p. Thanks.

>
>>      u8     duplex;
>>      u32    original_mtu;
>>      u32    link_failure_count;
>> @@ -504,10 +505,35 @@ static inline bool bond_is_slave_inactive(struct slave 
>> *slave)
>>      return slave->inactive;
>>  }
>[snip]
>> +
>> +static inline void bond_slave_link_notify(struct bonding *bond)
>> +{
>> +    struct list_head *iter;
>> +    struct slave *tmp;
>> +
>> +    bond_for_each_slave(bond, tmp, iter) {
>> +            if (tmp->should_notify_link) {
>> +                    bond_queue_slave_event(tmp);
>> +                    tmp->should_notify_link = 0;
>> +            }
>> +    }
>>  }
>>  
>>  static inline __be32 bond_confirm_addr(struct net_device *dev, __be32 dst, 
>> __be32 local)
>> 
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to