On Mon, Nov 30, 2015 at 9:32 AM, Lothar Waßmann <l...@karo-electronics.de> wrote:
> - gpio_set_value_cansleep(phy_reset, 1); > + gpiod_set_value_cansleep(phy_reset, 1); This will break some existing DTBs. Currently the fec driver does not care whether 'phy-reset-gpios' is active low or active high. (Yes, it was a mistake to assume in the driver that it is always active low.) After this change the polarity will be taken into account and may break some dtb's. I suggest you to send a single patch with the minimum changes to fix the regression caused by 8fff755e9f8d ("net: fec: Ensure clocks are enabled while using mdio bus"). -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html