On Tue, Oct 27, 2015 at 8:02 AM, Hannes Frederic Sowa <han...@stressinduktion.org> wrote: > CHECKSUM_PARTIAL skbs should never arrive in ip_fragment. If we get one > of those warn about them once and handle them gracefully by recalculating > the checksum. > > Cc: Eric Dumazet <eduma...@google.com> > Cc: Vlad Yasevich <vyasev...@gmail.com> > Cc: Benjamin Coddington <bcodd...@redhat.com> > Cc: Tom Herbert <t...@herbertland.com> > Signed-off-by: Hannes Frederic Sowa <han...@stressinduktion.org> > --- > net/ipv4/ip_output.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c > index 0b02417..3f94a3b 100644 > --- a/net/ipv4/ip_output.c > +++ b/net/ipv4/ip_output.c > @@ -533,6 +533,11 @@ int ip_do_fragment(struct net *net, struct sock *sk, > struct sk_buff *skb, > > dev = rt->dst.dev; > > + /* for offloaded checksums cleanup checksum before fragmentation */ > + if (WARN_ON_ONCE(skb->ip_summed == CHECKSUM_PARTIAL) && > + (err = skb_checksum_help(skb))) > + goto fail; > + Why the WARN_ON_ONCE? Is there a prior check somewhere that avoid this condition?
> /* > * Point into the IP datagram header. > */ > @@ -657,9 +662,6 @@ slow_path_clean: > } > > slow_path: > - /* for offloaded checksums cleanup checksum before fragmentation */ > - if ((skb->ip_summed == CHECKSUM_PARTIAL) && skb_checksum_help(skb)) > - goto fail; > iph = ip_hdr(skb); > > left = skb->len - hlen; /* Space per frame */ > -- > 2.5.0 > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
