Thu, Oct 01, 2015 at 05:44:55AM CEST, sfel...@gmail.com wrote: >On Wed, Sep 30, 2015 at 9:00 AM, Jiri Pirko <j...@resnulli.us> wrote: >> From: Jiri Pirko <j...@mellanox.com> >> >> Replace "void *obj" with a generic structure. Introduce couple of >> helpers along that. >> >> Signed-off-by: Jiri Pirko <j...@mellanox.com> > >Looks good to me, except for the macro/enum collision Vivien pointed >out. Vivien's suggestion to use SWITCHDEV_OBJ_ID_xxx for ID enums >would work.
ok > >Actually, id should be moved back into switchdev_obj, otherwise that >info is lost in dump callbacks. Could have a common callback that >switches on id, for id specific work. I'll submit a patch to move id >back into obj if Jiri doesn't add it to this one. I was thinking about it as well and it makes sense. I'll add it. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
